Lake fraction and depth in one regional domain #187
Conversation
…on to both global and regional domain (gtype=regional_gfdl). The resulting lake fraction and depth are added to oro data.
| @@ -83,14 +83,16 @@ elif [ $gtype = stretch ]; then | |||
| export target_lat=35.5 # Center latitude of the highest resolution tile | |||
| elif [ $gtype = nest ] || [ $gtype = regional_gfdl ]; then | |||
There was a problem hiding this comment.
I would set the default for add_lake to be false. And I would include a lake_cutoff variable. Please update the script prolog for these changes. The other four 'driver' scripts will need to be updated as well.
…on to both global and regional domain (gtype=regional_gfdl). The resulting lake fraction and depth are added to oro data.
…on to both global and regional domain (gtype=regional_gfdl). The resulting lake fraction and depth are added to oro data. add_lake is set to false by default.
|
Thanks for your careful review. Now add_lake is set to false by default and
lake_cutoff is included in all 'driver' scripts. Please let me know when
you have questions. -Shan
…On Mon, Oct 26, 2020 at 8:08 AM GeorgeGayno-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In driver_scripts/driver_grid.hera.sh
<#187 (comment)>:
> @@ -83,14 +83,16 @@ elif [ $gtype = stretch ]; then
export target_lat=35.5 # Center latitude of the highest resolution tile
elif [ $gtype = nest ] || [ $gtype = regional_gfdl ]; then
I would set the default for add_lake to be false. And I would include a
lake_cutoff variable. Please update the script prolog for these changes.
The other four 'driver' scripts will need to be updated as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#187 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVU35XROBTNTZRBHXI3SMV7ERANCNFSM4S62A6RA>
.
|
| export res=96 | ||
| export add_lake=false # Add lake frac and depth to orography data. | ||
| export lake_cutoff=0.20 # lake frac < lake_cutoff ignored when add_lake=T | ||
| export res=768 |
There was a problem hiding this comment.
I see you tested with a C768 regional grid. Will the lake code work with other resolutions?
|
For the regional_gfdl grid, we only tested C768, with specific domain
specifications that we got from Yihua. The code should work with other
resolutions with regional_gfdl, but we don't have the domain parameters to
test them.
Thanks,
Shan
…On Mon, Oct 26, 2020 at 11:16 AM GeorgeGayno-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In driver_scripts/driver_grid.cray.sh
<#187 (comment)>:
> elif [ $gtype = stretch ]; then
export res=96
export stretch_fac=1.5 # Stretching factor for the grid
export target_lon=-97.5 # Center longitude of the highest resolution tile
export target_lat=35.5 # Center latitude of the highest resolution tile
elif [ $gtype = nest ] || [ $gtype = regional_gfdl ]; then
- export res=96
+ export add_lake=false # Add lake frac and depth to orography data.
+ export lake_cutoff=0.20 # lake frac < lake_cutoff ignored when add_lake=T
+ export res=768
I see you tested with a C768 regional grid. Will the lake code work with
other resolutions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#187 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVTKHWMYYBDYSI6ZHVLSMWVGBANCNFSM4S62A6RA>
.
|
|
@YihuaWu-NOAA Are you satisfied these changes are working for the regional model? |
|
@shansun6 & @YihuaWu-NOAA Should I merge now or wait until you have the ESG grid working? |
|
I'd prefer to merge this commit, unless the ESG grid is ready to be tested
right now, to reduce the amount of catching up next time around. Make sense?
Thanks,
Shan
…On Tue, Oct 27, 2020 at 7:30 AM GeorgeGayno-NOAA ***@***.***> wrote:
@shansun6 <https://github.com/shansun6> & @YihuaWu-NOAA
<https://github.com/YihuaWu-NOAA> Should I merge now or wait until you
have the ESG grid working?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVXJ4J3WGBG5E5W63Q3SM3DPZANCNFSM4S62A6RA>
.
|
|
The branch at
Ok. Will merge now. |
|
The branch at aca0d79 was successfully compiled on Hera, Orion, Jet, WCOSS-Cray and WCOSS-Dell. The grid generation regression test was run on these machines and passed. Will merge. |
|
Thank you for your prompt response. -Shan
…On Tue, Oct 27, 2020 at 8:55 AM GeorgeGayno-NOAA ***@***.***> wrote:
The branch at aca0d79
<aca0d79>
was successfully compiled on Hera, Orion, Jet, WCOSS-Cray and WCOSS-Dell.
The grid generation regression test was run on these machines and passed.
Will merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALORMVX2XTHCC5TP2EZ24F3SM3NNXANCNFSM4S62A6RA>
.
|
This is to expand lake fraction and depth calculation to both global and regional domain (gtype=regional_gfdl). The resulting lake fraction and depth are added to oro data.
This refers to Issue #173